Move invite URL generation to on_ready event#175
Merged
CarrotManMatt merged 5 commits intoApr 21, 2024
Conversation
Moved invite URL generation to global function within utils/generate_invite_url.py.
Deleted utils/__main__.py and utils/base_utility_function.py.
Removed main() from utils/init.py.
Moved call to generate_invite_url() to startup.py.
- If main guild not set, invite URL will be outputted and bot will be shutdown.
- If main guild is set, invite URL will only be outputted if CONSOLE_LOG_LEVEL in environment variable set to DEBUG.
I had to modify tests for generate_invite_url() in test/tests_util.py reflect new behavior as it no longer takes in command line arguments.
- You may need to modify it accordingly to remove irrelevant test cases and adjust to new behavior.
codemicro
changed the title
on_ready event
Member
|
Closes #166 |
CarrotManMatt
requested changes
Apr 15, 2024
CarrotManMatt
left a comment
CarrotManMatt
left a comment
Member
There was a problem hiding this comment.
Really great work! I really appreciate your contributions🥰
In order for us to merge you changes the unit tests still need to pass here on GitHub, so you'll need to delete some of the unit-tests that are no longer relevant and include that in your pull request.
There are also a few changes I have suggested, let me know if you have any questions.
CarrotManMatt
added
good first issue
CarrotManMatt
approved these changes
Apr 21, 2024
Member
|
@edwinchan129 Thank you so much for your hard work on this! It looks great, and we appreciate you contributing in the future🥰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved invite URL generation to global function within utils/generate_invite_url.py. Deleted utils/main.py and utils/base_utility_function.py. Removed main() from utils/init.py.
Moved call to generate_invite_url() to startup.py.
- If main guild not set, invite URL will be outputted and bot will be shutdown.
- If main guild is set, invite URL will only be outputted if CONSOLE_LOG_LEVEL in environment variable set to DEBUG.
I had to modify tests for generate_invite_url() in test/tests_util.py in my own local test file to reflect new behavior as it no longer takes in command line arguments.
- You may need to modify it accordingly to remove irrelevant test cases and adjust to new behavior.